fmt: propagate read errors instead of silently treating them as EOF#12430
Open
gabrielhnf wants to merge 1 commit into
Open
fmt: propagate read errors instead of silently treating them as EOF#12430gabrielhnf wants to merge 1 commit into
gabrielhnf wants to merge 1 commit into
Conversation
|
GNU testsuite comparison: |
3101fed to
db48aa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10581
FileLinesiterator was silently swallowing IO errors by returning None on any read failure, making them indistinguishable from end-of-file. This caused fmt to exit successfully with code 0 when reading files that produce IO errors, such as/proc/self/mem.Changes:
FileLines::Itemis nowResult<Line, std::io::Error>, propagating read errors to callersParagraphStreamErrorenum to distinguish between unformatted passthrough lines and IO errorsParagraphStream::Itemis nowResult<Paragraph, ParagraphStreamError>process_filenow returns an error onParagraphStreamError::IoErrorinstead of iterating over an empty stream$ fmt /proc/self/memfails with exit code 1.