ls: fix leading space before first entry when color is enabled#12435
Open
hz2 wants to merge 1 commit into
Open
ls: fix leading space before first entry when color is enabled#12435hz2 wants to merge 1 commit into
hz2 wants to merge 1 commit into
Conversation
When --color is active and quoting is used, entry names are wrapped in ANSI escape sequences. The alignment logic that prepends a space to unquoted names was checking the raw first byte, which is now an ESC character rather than a quote. This caused a spurious leading space on every output line. Skip over ANSI CSI sequences before checking whether the name starts with a quote character. Fixes uutils#12432
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12432
Test plan