stdbuf: fix build.rs to propagate custom profiles to libstdbuf#12462
Open
Ecordonnier wants to merge 2 commits into
Open
stdbuf: fix build.rs to propagate custom profiles to libstdbuf#12462Ecordonnier wants to merge 2 commits into
Ecordonnier wants to merge 2 commits into
Conversation
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
… build
The PROFILE env var only returns the base profile name ('release' or 'debug'),
not the actual profile. For example, when building with --profile=release-small,
PROFILE=release, so the old code would pass --release to the nested libstdbuf
build, causing it to be compiled with release settings instead of release-small
settings (opt-level=z, strip=true, etc.).
Fix this by extracting the actual profile name from OUT_DIR, which always
contains the real profile name in its path (.../target/{profile}/build/...).
This correctly handles all custom profiles like release-small, profiling, etc.
Fixes: uutils#12434
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Ecordonnier
force-pushed
the
eco/stdbuf-profile
branch
from
83a11c9 to
96e6066
Compare
xtqqczze
reviewed
May 24, 2026
Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PROFILE env var only returns the base profile name ('release' or 'debug'), not the actual profile. For example, when building with --profile=release-small, PROFILE=release, so the old code would pass --release to the nested libstdbuf build, causing it to be compiled with release settings instead of release-small settings (opt-level=z, strip=true, etc.).
Fix this by extracting the actual profile name from OUT_DIR, which always contains the real profile name in its path (.../target/{profile}/build/...). This correctly handles all custom profiles like release-small, profiling, etc.
Fixes: #12434