Skip to content

New package: ananicy-cpp-1.2.0#59808

Open
lretq wants to merge 1 commit intovoid-linux:masterfrom
lretq:ananicy-cpp
Open

New package: ananicy-cpp-1.2.0#59808
lretq wants to merge 1 commit intovoid-linux:masterfrom
lretq:ananicy-cpp

Conversation

@lretq
Copy link
Copy Markdown
Contributor

@lretq lretq commented Apr 7, 2026

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

With the cross-build fixes also for: x86_64-musl, aarch64-glibc, aarch64-musl

@lretq
Copy link
Copy Markdown
Contributor Author

lretq commented Apr 7, 2026

I will have to look into the musl build

@lretq lretq marked this pull request as draft April 7, 2026 20:28
@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Apr 7, 2026
Copy link
Copy Markdown
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the service should be tweaking sysctls. Let people configure their systems to support the daemon if they want to run it. In any case, there is no good reason for using two different approaches to setting sysctls in the run and finish scripts.

@lretq lretq force-pushed the ananicy-cpp branch 2 times, most recently from 2152e35 to 61068aa Compare April 9, 2026 17:54
@lretq
Copy link
Copy Markdown
Contributor Author

lretq commented Apr 9, 2026

I'm not sure that the service should be tweaking sysctls. Let people configure their systems to support the daemon if they want to run it. In any case, there is no good reason for using two different approaches to setting sysctls in the run and finish scripts.

I took that part out. Should I provide some sort of sysctl.d/ananicy.conf example file?

@lretq lretq marked this pull request as ready for review April 9, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants