Skip to content

bug: bad comparsion between extension types#7523

Closed
joseph-isaacs wants to merge 1 commit into
developfrom
ji/timestamp-bug
Closed

bug: bad comparsion between extension types#7523
joseph-isaacs wants to merge 1 commit into
developfrom
ji/timestamp-bug

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

fix me.

likely we need to remove or only allow for same type same storage type.

I think we need to register kernels that actually op-in to timestamp timestamp comparison.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs requested a review from gatesn April 17, 2026 22:57
@codspeed-hq

codspeed-hq Bot commented Apr 17, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 18.83%

❌ 3 regressed benchmarks
✅ 1160 untouched benchmarks
⏩ 1457 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation old_alp_prim_test_between[f64, 32768] 284.8 µs 350.9 µs -18.83%
Simulation decompress_rd[f64, (100000, 0.01)] 2 ms 2.3 ms -13.41%
Simulation decompress_rd[f64, (100000, 0.1)] 2 ms 2.3 ms -13.41%

Comparing ji/timestamp-bug (80d1205) with develop (4135209)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label May 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions Bot closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant