feat: iterative execution for DateTimePartsArray#7698
Merged
Conversation
Move require_child! before inline execute_mask so the child is executed through the scheduler, enabling cross-step optimization via reduce_parent rules. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add #[array_slots] macro for DateTimePartsSlots - Add DateTimePartsParts struct + OwnedExt trait for into_parts(self) - require_child! days => Primitive, seconds/subseconds => AnyCanonical - decode_to_temporal handles Constant fast path for seconds/subseconds Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…me-parts Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will degrade performance by 31.37%
Performance Changes
Comparing 
Footnotes
|
…me-parts Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-array/src/arrays/masked/array.rs # vortex-array/src/arrays/masked/vtable/mod.rs
0ax1
reviewed
Apr 29, 2026
| fn fmt(&self, _f: &mut Formatter<'_>) -> std::fmt::Result { | ||
| Ok(()) | ||
| } | ||
| pub struct DateTimePartsParts { |
Contributor
There was a problem hiding this comment.
This has the same fields as DateTimePartsSlots do we need both?
Contributor
Author
There was a problem hiding this comment.
I think consistency beats duplication?
0ax1
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.