Skip to content

Json-Variant exprs#8391

Draft
AdamGS wants to merge 2 commits into
developfrom
adamg/variant-json-handling
Draft

Json-Variant exprs#8391
AdamGS wants to merge 2 commits into
developfrom
adamg/variant-json-handling

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Supersedes #8156

@AdamGS AdamGS mentioned this pull request Jun 12, 2026
@AdamGS AdamGS force-pushed the adamg/variant-json-handling branch from 860196c to b9ae199 Compare June 12, 2026 16:27
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 15.45%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 3 regressed benchmarks
✅ 1541 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.5 µs 35.6 µs -42.32%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 176.5 µs 213.2 µs -17.19%
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.4 µs 308.2 µs -11.3%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 215.8 µs 178.9 µs +20.6%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/variant-json-handling (b5d833f) with develop (01ea0fd)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (0511832) during the generation of this report, so 01ea0fd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-json-handling branch from b9ae199 to 1e84175 Compare June 15, 2026 13:19
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant