fix: skip device auth when unclaimed environment is active#115
Merged
fix: skip device auth when unclaimed environment is active#115
Conversation
checkStoredAuth only checked for OAuth tokens, so the state machine forced device auth even when a valid unclaimed environment (with apiKey + claimToken) was already active. This caused the CLI to hang on "Waiting for authentication..." after the browser showed success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkStoredAuthin the installer state machine only checked for OAuth tokens (getAccessToken()), ignoring active unclaimed environments that already have validapiKey+claimTokencheckStoredAuthrecognizes unclaimed environments as valid auth, skipping device auth and flowing directly tofetchingStagingCredentials(which already handles unclaimed envs)Test plan
pnpm buildpassespnpm typecheckpassespnpm testpassesworkos installskips device auth and proceeds directly