Quote glob pattern examples in --include/--exclude docs to prevent shell expansion#490
Merged
swissspidy merged 4 commits intomainfrom Apr 21, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/wp-cli/i18n-command/sessions/7804f419-f086-4ce0-b24d-7a1dc23a7737 Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update glob examples for include/exclude with quotes
Quote glob pattern examples in --include/--exclude docs to prevent shell expansion
Apr 21, 2026
github-actions
Bot
added
command:i18n-make-pot
swissspidy
approved these changes
Apr 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CLI documentation examples to ensure glob patterns in --include/--exclude are quoted so shells don’t expand them before WP-CLI receives the arguments.
Changes:
- Quote glob pattern examples for
--includeand--excludein command docblocks. - Mirror the same quoting updates in
README.mdfor the rendered docs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MakePotCommand.php | Quotes glob examples in --include/--exclude option docs. |
| src/AuditCommand.php | Quotes glob example in --exclude option docs. |
| README.md | Mirrors the quoted glob examples in the generated/hand-maintained docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell globbing expands unquoted patterns like
--exclude=foo-*.phpbefore WP-CLI sees them, producing silent unexpected behavior when matching files exist in the current directory.Changes
src/MakePotCommand.php— Quote glob examples in--includeand--excludeoption docssrc/AuditCommand.php— Quote glob example in--excludeoption docsREADME.md— Mirror the same fixes across all three occurrencesBefore:
After: