Skip to content

fix: avoid per-instantiation vtable issues with MinGW GCC #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DiamonDinoia wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −10
Open

fix: avoid per-instantiation vtable issues with MinGW GCC #1290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions test/test_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,27 +386,47 @@ namespace detail
b.store_unaligned(dst.data() + i);
}

// Non-template context scope to avoid per-instantiation vtable issues with MinGW GCC.
// INFO() creates a ContextScope<Lambda> with a unique vtable per template instantiation.
// This concrete class has a single vtable definition shared across all instantiations.
struct StringContextScope : doctest::detail::ContextScopeBase
{
std::string msg_;
explicit StringContextScope(std::string msg)
: msg_(std::move(msg))
{
}
void stringify(std::ostream* os) const override { *os << msg_; }
};

template <class T>
StringContextScope make_context_info(const char* name, const T& val)
{
return StringContextScope(std::string(name) + ":" + doctest::toString(val).c_str());
}
}

#define CHECK_BATCH_EQ(b1, b2) \
do \
{ \
INFO(#b1 ":", b1); \
INFO(#b2 ":", b2); \
CHECK_UNARY(::detail::expect_batch_near(b1, b2)); \
// Use make_context_info instead of INFO() to avoid MinGW GCC vtable issues
// (see StringContextScope above).
#define CHECK_BATCH_EQ(b1, b2) \
do \
{ \
auto _ctx1 = ::detail::make_context_info(#b1, b1); \
Copy link
Copy Markdown
Contributor

@serge-sans-paille serge-sans-paille Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a small comment here and below to explain why we're doing something smart :-)

auto _ctx2 = ::detail::make_context_info(#b2, b2); \
CHECK_UNARY(::detail::expect_batch_near(b1, b2)); \
} while (0)
#define CHECK_SCALAR_EQ(s1, s2) \
do \
{ \
INFO(#s1 ":", s1); \
INFO(#s2 ":", s2); \
auto _ctx1 = ::detail::make_context_info(#s1, s1); \
auto _ctx2 = ::detail::make_context_info(#s2, s2); \
CHECK_UNARY(::detail::expect_scalar_near(s1, s2)); \
} while (0)
#define CHECK_VECTOR_EQ(v1, v2) \
do \
{ \
INFO(#v1 ":", v1); \
INFO(#v2 ":", v2); \
auto _ctx1 = ::detail::make_context_info(#v1, v1); \
auto _ctx2 = ::detail::make_context_info(#v2, v2); \
CHECK_UNARY(::detail::expect_vector_near(v1, v2)); \
} while (0)

Expand Down
Loading