-
-
Notifications
You must be signed in to change notification settings - Fork 27
Remove QueueInterface::withAdapter() and AdapterFactoryQueueProvider
#266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
9041732
77fbe0b
df494f2
26b9eab
95045ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,22 +17,12 @@ | |
| use Yiisoft\Queue\Middleware\Push\MiddlewareFactoryPush; | ||
| use Yiisoft\Queue\Middleware\Push\MiddlewareFactoryPushInterface; | ||
| use Yiisoft\Queue\Middleware\Push\PushMiddlewareDispatcher; | ||
| use Yiisoft\Queue\Provider\AdapterFactoryQueueProvider; | ||
| use Yiisoft\Queue\Provider\QueueProviderInterface; | ||
| use Yiisoft\Queue\Queue; | ||
| use Yiisoft\Queue\QueueInterface; | ||
| use Yiisoft\Queue\Worker\Worker as QueueWorker; | ||
| use Yiisoft\Queue\Worker\WorkerInterface; | ||
|
|
||
| /* @var array $params */ | ||
|
|
||
| return [ | ||
| AdapterFactoryQueueProvider::class => [ | ||
| '__construct()' => [ | ||
| 'definitions' => $params['yiisoft/queue']['queues'], | ||
| ], | ||
| ], | ||
| QueueProviderInterface::class => AdapterFactoryQueueProvider::class, | ||
| QueueWorker::class => [ | ||
| 'class' => QueueWorker::class, | ||
| '__construct()' => [$params['yiisoft/queue']['handlers']], | ||
|
|
@@ -43,7 +33,6 @@ | |
| ? $container->get(SignalLoop::class) | ||
| : $container->get(SimpleLoop::class); | ||
| }, | ||
| QueueInterface::class => Queue::class, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is assumed that the queue or queue provider will be configured in the container configuration in the application. |
||
| MiddlewareFactoryPushInterface::class => MiddlewareFactoryPush::class, | ||
| MiddlewareFactoryConsumeInterface::class => MiddlewareFactoryConsume::class, | ||
| MiddlewareFactoryFailureInterface::class => MiddlewareFactoryFailure::class, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use Yiisoft\Queue\Adapter\AdapterInterface; | ||
| use Yiisoft\Queue\Command\ListenAllCommand; | ||
| use Yiisoft\Queue\Command\ListenCommand; | ||
| use Yiisoft\Queue\Command\RunCommand; | ||
|
|
@@ -22,9 +21,6 @@ | |
| ], | ||
| 'yiisoft/queue' => [ | ||
| 'handlers' => [], | ||
| 'queues' => [ | ||
| QueueProviderInterface::DEFAULT_QUEUE => AdapterInterface::class, | ||
| ], | ||
|
Comment on lines
-25
to
-27
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How to configure queues with this change?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is assumed that the queue provider will be configured in the container configuration in the application. |
||
| 'middlewares-push' => [], | ||
| 'middlewares-consume' => [], | ||
| 'middlewares-fail' => [], | ||
|
|
||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? How to get a named queue now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is assumed that the queue provider will be configured in the container configuration in the application.