Tests for encrypted email support#40
Open
krrico wants to merge 1 commit into
Open
Conversation
…ssertions can handle Message objects as well
krrico
commented
May 22, 2026
|
|
||
| final readonly class Crypto | ||
| { | ||
| public function generateSslCertificate(): string |
Author
There was a problem hiding this comment.
This right here is a bit of a heavy overhead for testing this but necessary for the SMimeEncrypter to generate an encrypted e-mail. Maybe adding a test certificate directly into the tests/_data directory would be better. Any opinions on that?
Another option would be to fake "encryption" and just turn an Email object into a plain Message object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for sending encrypted emails and ensure mailer and mime a…ssertions can handle Message objects as well.
Fixing this issue: Codeception/module-symfony#233
Tests for those changes: Codeception/module-symfony#232