-
Notifications
You must be signed in to change notification settings - Fork 13
Tests for encrypted email support #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krrico
wants to merge
1
commit into
Codeception:5.4
Choose a base branch
from
krrico:feature/support_encrypted_emails
base: 5.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\Controller; | ||
|
|
||
| use App\Entity\User; | ||
| use App\Utils\Mailer; | ||
| use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| final class SendEncryptedEmailController extends AbstractController | ||
| { | ||
| public function __construct( | ||
| private readonly Mailer $mailer, | ||
| ) { | ||
| } | ||
|
|
||
| public function __invoke(): Response | ||
| { | ||
| $this->mailer->sendEncryptedEmail((new User())->setEmail('jane_doe@example.com')); | ||
|
|
||
| return $this->json(['message' => 'Encrypted email sent successfully']); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\Utils; | ||
|
|
||
| final readonly class Crypto | ||
| { | ||
| public function generateSslCertificate(): string | ||
| { | ||
| if (!extension_loaded('openssl')) { | ||
| throw new \RuntimeException('OpenSSL extension is required.'); | ||
| } | ||
|
|
||
| $privateKey = openssl_pkey_new(); | ||
| $certSignRequest = openssl_csr_new([], $privateKey); | ||
| $certificate = openssl_csr_sign($certSignRequest, null, $privateKey, 1); | ||
|
|
||
| $tmpDir = sys_get_temp_dir(); | ||
| $privateKeyPath = tempnam($tmpDir, 'pkey'); | ||
| $certificatePath = tempnam($tmpDir, 'cert'); | ||
|
|
||
| if (!openssl_pkey_export_to_file($privateKey, $privateKeyPath, 'powercloud')) { | ||
| throw new \RuntimeException('Private key generation failed: ' . openssl_error_string()); | ||
| } | ||
| if (!openssl_x509_export_to_file($certificate, $certificatePath)) { | ||
| throw new \RuntimeException('OpenSSL certificate generation failed: ' . openssl_error_string()); | ||
| } | ||
|
|
||
| register_shutdown_function(static function () use ($privateKeyPath, $certificatePath): void { | ||
| unlink($privateKeyPath); | ||
| unlink($certificatePath); | ||
| }); | ||
|
|
||
| return $certificatePath; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This right here is a bit of a heavy overhead for testing this but necessary for the SMimeEncrypter to generate an encrypted e-mail. Maybe adding a test certificate directly into the tests/_data directory would be better. Any opinions on that?
Another option would be to fake "encryption" and just turn an Email object into a plain Message object.