Skip to content

Update tests-pr.yml#7140

Open
farmeratwork wants to merge 1 commit intoShopify:mainfrom
farmeratwork:main
Open

Update tests-pr.yml#7140
farmeratwork wants to merge 1 commit intoShopify:mainfrom
farmeratwork:main

Conversation

@farmeratwork
Copy link
Copy Markdown

debug PR head and runid

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

debug PR head and runid
@farmeratwork farmeratwork requested a review from a team as a code owner April 1, 2026 05:15
Copilot AI review requested due to automatic review settings April 1, 2026 05:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR test workflow to print additional GitHub context for debugging which commit/repo is being executed.

Changes:

  • Add a debug/PoC step to echo PR head repo, PR head SHA, and the workflow run id.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +148 to +152
- name: PoC: confirm PR head executed
run: |
echo "PR head repo: ${{ github.event.pull_request.head.repo.full_name }}"
echo "PR head sha: ${{ github.event.pull_request.head.sha }}"
echo "Run id: ${{ github.run_id }}"
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step uses github.event.pull_request.* directly, but the workflow is also triggered by merge_group (see top of file). On merge_group runs these fields will be empty/undefined, so the output won’t accurately reflect what was checked out. Consider either guarding this step with if: github.event_name == 'pull_request' or using the same fallback expressions used by actions/checkout (e.g., ...head.repo.full_name || github.event.repository.full_name and ...head.sha || github.sha).

Copilot uses AI. Check for mistakes.
Comment on lines +148 to +152
- name: PoC: confirm PR head executed
run: |
echo "PR head repo: ${{ github.event.pull_request.head.repo.full_name }}"
echo "PR head sha: ${{ github.event.pull_request.head.sha }}"
echo "Run id: ${{ github.run_id }}"
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a temporary PoC/debug logging step. If it’s only needed for short-term troubleshooting, consider removing it once validated, or gating it behind an input/env flag to avoid adding log noise to every PR run.

Suggested change
- name: PoC: confirm PR head executed
run: |
echo "PR head repo: ${{ github.event.pull_request.head.repo.full_name }}"
echo "PR head sha: ${{ github.event.pull_request.head.sha }}"
echo "Run id: ${{ github.run_id }}"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants