Skip to content

Update tests-pr.yml #7140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farmeratwork wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Update tests-pr.yml #7140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,12 @@ jobs:
run: pnpm build-dev-docs
- name: Check if there are changes
run: 'test -z "$(git status --porcelain "docs-shopify.dev/generated/*.json" )" || { echo -e "Run (pnpm build-dev-docs) before pushing new commands or flags." ; exit 1; }'
- name: PoC: confirm PR head executed
run: |
echo "PR head repo: ${{ github.event.pull_request.head.repo.full_name }}"
echo "PR head sha: ${{ github.event.pull_request.head.sha }}"
echo "Run id: ${{ github.run_id }}"
Comment on lines +148 to +152
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step uses github.event.pull_request.* directly, but the workflow is also triggered by merge_group (see top of file). On merge_group runs these fields will be empty/undefined, so the output won’t accurately reflect what was checked out. Consider either guarding this step with if: github.event_name == 'pull_request' or using the same fallback expressions used by actions/checkout (e.g., ...head.repo.full_name || github.event.repository.full_name and ...head.sha || github.sha).

Copilot uses AI. Check for mistakes.
Comment on lines +148 to +152
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a temporary PoC/debug logging step. If it’s only needed for short-term troubleshooting, consider removing it once validated, or gating it behind an input/env flag to avoid adding log noise to every PR run.

Suggested change
- name: PoC: confirm PR head executed
run: |
echo "PR head repo: ${{ github.event.pull_request.head.repo.full_name }}"
echo "PR head sha: ${{ github.event.pull_request.head.sha }}"
echo "Run id: ${{ github.run_id }}"

Copilot uses AI. Check for mistakes.


unit-tests:
name: "Unit tests with Node ${{ matrix.node }} in ${{ matrix.os }}${{ matrix.shard != '' && format(' (shard {0})', matrix.shard) || '' }}"
Expand Down
Loading