Skip to content

doc: change 'implementation' to 'feature' in snapshot guide#22952

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:release-8.5from
yahonda:fix-en-snapshot-guide-implementation
Jun 3, 2026
Merged

doc: change 'implementation' to 'feature' in snapshot guide#22952
ti-chi-bot[bot] merged 3 commits into
pingcap:release-8.5from
yahonda:fix-en-snapshot-guide-implementation

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented May 27, 2026

The term 'implementation' was likely a direct translation from Chinese '实现' and sounds unnatural in English. This also prevents unnatural translations in other languages, such as '実装' in Japanese.

The term 'implementation' was likely a direct translation from Chinese '实现' and sounds unnatural in English. This also prevents unnatural translations in other languages, such as '実装' in Japanese.
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BR snapshot guide to refer to snapshot backup as a "feature" rather than an "implementation". The reviewer suggested rephrasing the sentence to use the second person ("you") and active voice ("completes" instead of "is completed") to align with the style guide.

Comment thread br/br-snapshot-guide.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread br/br-snapshot-guide.md Outdated
@qiancai qiancai added the translation/no-need No need to translate this PR. label Jun 3, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jun 3, 2026
@qiancai qiancai added needs-cherry-pick-master Should cherry pick this PR to master branch. missing-translation-status This PR does not have translation status info. labels Jun 3, 2026
@qiancai qiancai self-assigned this Jun 3, 2026
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Jun 3, 2026

/approve

@qiancai qiancai added the lgtm label Jun 3, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 3, 2026
@qiancai qiancai removed the missing-translation-status This PR does not have translation status info. label Jun 3, 2026
@ti-chi-bot ti-chi-bot Bot merged commit cd816b1 into pingcap:release-8.5 Jun 3, 2026
11 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch master: #22997.

@yahonda yahonda deleted the fix-en-snapshot-guide-implementation branch June 3, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants