Skip to content

doc: change 'implementation' to 'feature' in snapshot guide (#22952)#22997

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-22952-to-master
Jun 3, 2026
Merged

doc: change 'implementation' to 'feature' in snapshot guide (#22952)#22997
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-22952-to-master

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #22952

The term 'implementation' was likely a direct translation from Chinese '实现' and sounds unnatural in English. This also prevents unnatural translations in other languages, such as '実装' in Japanese.

yahonda and others added 3 commits June 3, 2026 07:24
The term 'implementation' was likely a direct translation from Chinese '实现' and sounds unnatural in English. This also prevents unnatural translations in other languages, such as '実装' in Japanese.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. labels Jun 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the phrasing in the TiDB snapshot backup and restore guide. The reviewer suggested further refining the updated paragraph to improve clarity, flow, and grammar (such as changing 'conflict data' to 'conflicting data' and reducing the repetitive use of 'restore') by providing a structured rewrite suggestion.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread br/br-snapshot-guide.md
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Jun 3, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 3, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 4390534 into pingcap:master Jun 3, 2026
11 checks passed
@ti-chi-bot ti-chi-bot Bot deleted the cherry-pick-22952-to-master branch June 3, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants