Skip to content

i18n(ja): Fix Pump and Drainer mistranslations#22976

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:topic/fix-ja-pump-drainer-release-8.5
Open

i18n(ja): Fix Pump and Drainer mistranslations#22976
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:topic/fix-ja-pump-drainer-release-8.5

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented Jun 1, 2026

  • ポンプ -> Pump
  • ドレイナー -> Drainer
  • Pumppanic -> Pump panic

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 1, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2026
@yahonda yahonda mentioned this pull request Jun 1, 2026
Closed
16 tasks
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes terminology in several Japanese release notes by replacing katakana terms like 'ポンプ' and 'ドレイナー' with their English equivalents 'Pump' and 'Drainer', while also improving overall sentence flow. The review feedback suggests further simplifying the phrase '最大値commit_ts' to '最大commit_ts' in two files to eliminate redundant wording and enhance readability.

Comment thread releases/release-2.1.18.md Outdated
Comment thread releases/release-3.0.5.md Outdated
@yahonda
i18n(ja): Fix Pump and Drainer mistranslations in release notes
8832c1c 
- ポンプ -> Pump
- ドレイナー -> Drainer
- Pumppanic -> Pump panic
@yahonda yahonda force-pushed the topic/fix-ja-pump-drainer-release-8.5 branch from 6fd14fd to 8832c1c Compare June 1, 2026 05:51
@yahonda yahonda marked this pull request as ready for review June 1, 2026 05:52
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yahonda