Drop xfail on test_external_cog_validator now that #2308 is fixed#2310
Merged
brendancol merged 1 commit intoMay 22, 2026
Merged
Conversation
…is fixed The xfail was added in xarray-contrib#2304 as a placeholder so the rio-cogeo CI gate could land green while the overview block ordering bug was being fixed. xarray-contrib#2309 landed that writer fix, so the test now passes -- drop the marker and the accompanying comment.
Contributor
Author
Self-reviewDiff is 16 deletions: the Verified locally with rio-cogeo installed: Blockers
Suggestions
Nits
Checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2304 and #2309.
#2304 wired up the rio-cogeo CI gate and marked
test_external_cog_validatoras xfail (strict=False) because the writer emitted overview tile blocks in the wrong order (#2308). #2309 fixed the writer, so the test now passes locally withXRSPATIAL_REQUIRE_COG_VALIDATOR=1. Drop the marker and the comment block that pointed at #2308.Verified locally with rio-cogeo installed: the test goes from XPASS (silent under strict=False) to PASS. Final validation is the
run (3.12)pytest-cog-validator job on this PR.Diff is the decorator plus its preceding comment block, nothing else.