Skip to content

Drop xfail on test_external_cog_validator now that #2308 is fixed#2310

Merged
brendancol merged 1 commit into
xarray-contrib:mainfrom
brendancol:drop-xfail-test-external-cog-validator
May 22, 2026
Merged

Drop xfail on test_external_cog_validator now that #2308 is fixed#2310
brendancol merged 1 commit into
xarray-contrib:mainfrom
brendancol:drop-xfail-test-external-cog-validator

Conversation

@brendancol
Copy link
Copy Markdown
Contributor

Follow-up to #2304 and #2309.

#2304 wired up the rio-cogeo CI gate and marked test_external_cog_validator as xfail (strict=False) because the writer emitted overview tile blocks in the wrong order (#2308). #2309 fixed the writer, so the test now passes locally with XRSPATIAL_REQUIRE_COG_VALIDATOR=1. Drop the marker and the comment block that pointed at #2308.

Verified locally with rio-cogeo installed: the test goes from XPASS (silent under strict=False) to PASS. Final validation is the run (3.12) pytest-cog-validator job on this PR.

Diff is the decorator plus its preceding comment block, nothing else.

…is fixed

The xfail was added in xarray-contrib#2304 as a placeholder so the rio-cogeo CI gate
could land green while the overview block ordering bug was being fixed.
xarray-contrib#2309 landed that writer fix, so the test now passes -- drop the marker
and the accompanying comment.
@github-actions github-actions Bot added the performance PR touches performance-sensitive code label May 22, 2026
@brendancol
Copy link
Copy Markdown
Contributor Author

Self-review

Diff is 16 deletions: the @pytest.mark.xfail decorator on test_external_cog_validator and the preceding comment block that pointed at #2308. Test body is unchanged.

Verified locally with rio-cogeo installed:

XRSPATIAL_REQUIRE_COG_VALIDATOR=1 pytest \
  xrspatial/geotiff/tests/test_cog_writer_compliance.py::test_external_cog_validator -v
...
xrspatial/geotiff/tests/test_cog_writer_compliance.py::test_external_cog_validator PASSED

Blockers

  • none

Suggestions

  • none

Nits

  • none

Checklist

  • Behavior change is the decorator removal only
  • Test passes locally under the strict env var
  • No other files touched
  • CI run (3.12) pytest-cog-validator job is the final gate

@brendancol brendancol merged commit bb12555 into xarray-contrib:main May 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PR touches performance-sensitive code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant